@@ -1115,6 +1241,7 @@ defmodule WhoNeedHelpWeb.RequestLive.Show do
<.form
:if={
Help.helper?(@current_scope, @assignment) &&
+ @assignment.status in [:accepted, :in_progress] &&
is_nil(@assignment.handover_verified_at)
}
id="handover-form"
diff --git a/test/who_need_help/mutual_aid_flow_test.exs b/test/who_need_help/mutual_aid_flow_test.exs
index 8961682..d6b75d7 100644
--- a/test/who_need_help/mutual_aid_flow_test.exs
+++ b/test/who_need_help/mutual_aid_flow_test.exs
@@ -167,6 +167,41 @@ defmodule WhoNeedHelp.MutualAidFlowTest do
Messaging.send_message(outsider_scope, assignment, %{"body" => "not allowed"})
end
+ test "cancelling in-progress help closes interaction and deletes live positions", context do
+ {:ok, request} = Help.create_request(context.requester_scope, context.request_attrs)
+ {:ok, assignment} = Help.accept_request(context.helper_scope, request.id)
+ {:ok, assignment} = Help.start_assignment(context.helper_scope, assignment.id)
+
+ {:ok, message} =
+ Messaging.send_message(context.helper_scope, assignment, %{"body" => "I have started."})
+
+ {:ok, tracking_session} = Tracking.start_session(context.helper_scope, assignment)
+
+ {:ok, _position} =
+ Tracking.update_position(context.helper_scope, assignment, %{
+ "latitude" => 50.45,
+ "longitude" => 30.52,
+ "accuracy_meters" => 8.0
+ })
+
+ assert {:ok, cancelled_request} =
+ Help.cancel_request(context.requester_scope, request.id)
+
+ assert cancelled_request.status == :cancelled
+ assert cancelled_request.assignment.status == :cancelled
+ refute Repo.get_by(Position, tracking_session_id: tracking_session.id)
+
+ assert {:error, :assignment_inactive} =
+ Messaging.send_message(context.helper_scope, assignment, %{
+ "body" => "This must not be stored."
+ })
+
+ assert [%{id: message_id, body: "I have started."}] =
+ Messaging.list_messages(context.requester_scope, assignment)
+
+ assert message_id == message.id
+ end
+
test "participants can mark only counterpart messages as read", context do
outsider_scope = user_fixture(display_name: "Outsider") |> user_scope_fixture()
{:ok, request} = Help.create_request(context.requester_scope, context.request_attrs)
diff --git a/test/who_need_help_web/live/mutual_aid_live_test.exs b/test/who_need_help_web/live/mutual_aid_live_test.exs
index 9c5e481..371c2ab 100644
--- a/test/who_need_help_web/live/mutual_aid_live_test.exs
+++ b/test/who_need_help_web/live/mutual_aid_live_test.exs
@@ -625,6 +625,89 @@ defmodule WhoNeedHelpWeb.MutualAidLiveTest do
refute has_element?(view, "#message-form")
end
+ test "unblocking restores active match history without a page reload", %{
+ conn: requester_conn,
+ scope: requester_scope
+ } do
+ category = Catalog.seed_defaults()
+ helper = user_fixture(display_name: "Restored helper")
+
+ {:ok, request} = Help.create_request(requester_scope, request_attrs(category))
+ {:ok, assignment} = Help.accept_request(user_scope_fixture(helper), request.id)
+
+ {:ok, _message} =
+ Messaging.send_message(user_scope_fixture(helper), assignment, %{
+ "body" => "Restore this message after unblocking."
+ })
+
+ {:ok, view, html} = live(requester_conn, ~p"/requests/#{request.id}")
+ assert html =~ "Restore this message after unblocking."
+ assert has_element?(view, "#message-form")
+
+ view
+ |> element("button[phx-click='block-user']")
+ |> render_click()
+
+ blocked_html = render(view)
+ assert blocked_html =~ "This interaction is blocked."
+ refute blocked_html =~ "Restore this message after unblocking."
+ refute has_element?(view, "#message-form")
+
+ view
+ |> element("button[phx-click='unblock-user']")
+ |> render_click()
+
+ restored_html = render(view)
+ assert restored_html =~ "Restore this message after unblocking."
+ assert has_element?(view, "#message-form")
+ end
+
+ test "cancelled in-progress help keeps history read-only and hides handover actions" do
+ category = Catalog.seed_defaults()
+ requester = user_fixture(display_name: "Cancelling requester")
+ helper = user_fixture(display_name: "Cancelled helper")
+ requester_scope = user_scope_fixture(requester)
+ helper_scope = user_scope_fixture(helper)
+
+ {:ok, request} = Help.create_request(requester_scope, request_attrs(category))
+ {:ok, assignment} = Help.accept_request(helper_scope, request.id)
+
+ {:ok, _message} =
+ Messaging.send_message(helper_scope, assignment, %{"body" => "Visible history."})
+
+ {:ok, requester_view, _html} =
+ build_conn() |> log_in_user(requester) |> live(~p"/requests/#{request.id}")
+
+ {:ok, helper_view, _html} =
+ build_conn() |> log_in_user(helper) |> live(~p"/requests/#{request.id}")
+
+ helper_view
+ |> element("button[phx-click='start']")
+ |> render_click()
+
+ assert render(helper_view) =~ "Help is now in progress."
+
+ requester_view
+ |> element("button[phx-click='cancel-request']")
+ |> render_click()
+
+ for view <- [requester_view, helper_view] do
+ html = render(view)
+ assert html =~ "This match was cancelled"
+ assert html =~ "This request was cancelled."
+ refute html =~ "Help is now in progress."
+ assert html =~ "Chat history is read-only"
+ assert html =~ "Visible history."
+ refute has_element?(view, "#message-form")
+ refute has_element?(view, "#handover-form")
+ refute has_element?(view, "#copy-handover-code")
+ refute has_element?(view, "button[phx-click='confirm']")
+ end
+
+ stop_live_view(requester_view)
+ stop_live_view(helper_view)
+ end
+
test "terminal request updates stop Android foreground tracking", _context do
category = Catalog.seed_defaults()
requester = user_fixture(display_name: "Tracking requester")